[all-commits] [llvm/llvm-project] 710fa2: [lldb] Make module-ownership.mm test more robust a...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Fri May 8 04:44:44 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 710fa2c4ee346e1ec2db66ac5fdf6909e79d9a8c
      https://github.com/llvm/llvm-project/commit/710fa2c4ee346e1ec2db66ac5fdf6909e79d9a8c
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M lldb/test/Shell/SymbolFile/DWARF/module-ownership.mm

  Log Message:
  -----------
  [lldb] Make module-ownership.mm test more robust against AST node ordering

The current test is checking both the anonymous structs and the template
specializations in one FileCheck run, but the anonymous struct line can
partially match the AST dump of a template specialization, causing that
FileCheck won't match that same line later against the template specialization
check and incorrectly fails on that check. This only happens when the
template specialization node somehow ends up before the anonymous struct node.

This patch just puts the checks for the anonymous structs in their own FileCheck
run to prevent them from partially matching any other record decl.

Fixes rdar://62997926




More information about the All-commits mailing list