[all-commits] [llvm/llvm-project] aaf68c: [lldb] Warn the user about starting the --func-reg...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: aaf68cd9ce2fda224e02fd0f860e6372b4b00e47
      https://github.com/llvm/llvm-project/commit/aaf68cd9ce2fda224e02fd0f860e6372b4b00e47
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M lldb/source/Commands/CommandObjectBreakpoint.cpp
    M lldb/test/API/commands/breakpoint/set/func-regex/TestBreakpointRegexError.py

  Log Message:
  -----------
  [lldb] Warn the user about starting the --func-regex parameter with an asterisk

Summary:
Sometimes users think that setting a function regex for all function that contain the word 'needle' in their
name looks like this: `*needle*`. However, LLDB only searches the function name and doesn't fully match
it against the regex, so the leading and trailing '*' operators don't do anything and actually just cause the
regex engine to reject the regular expression with "repetition-operator operand invalid".

This patch makes this a bit more obvious to the user by printing a warning that a leading '*' before this
regular expression here doesn't have any purpose (and will cause an error). This doesn't attempt to detect
a case where there is only a trailing '*' as that would involve parsing the regex and it seems the most
common way to end up in this situation is by doing `rbreak *needle*`.

Reviewers: JDevlieghere

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D78809