[all-commits] [llvm/llvm-project] 9d273c: [mlir] Harden verifiers for DMA ops

[ftynse via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d273c0ef032445402c332ff7c896d661fca5747
      https://github.com/llvm/llvm-project/commit/9d273c0ef032445402c332ff7c896d661fca5747
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-05-05 (Tue, 05 May 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.h
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    M mlir/test/IR/invalid-ops.mlir

  Log Message:
  -----------
  [mlir] Harden verifiers for DMA ops

DMA operation classes in the Standard dialect (`DmaStartOp` and `DmaWaitOp`)
provide helper functions that make numerous assumptions about the number and
order of operands, and about their types. However, these assumptions were not
checked in the verifier, leading to assertion failures or crashes when helper
functions were used on ill-formed ops. Some of the assuptions were checked in
the custom parser (and thus could not check assumption violations in ops
constructed programmatically, e.g., during rewrites) and others were not
checked at all. Introduce the verifiers for all these assumptions and drop
unnecessary checks in the parser that are now covered by the verifier.

Addresses PR45560.

Differential Revision: https://reviews.llvm.org/D79408