[all-commits] [llvm/llvm-project] d87001: [clangd] Get rid of Inclusion::R

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Tue May 5 03:24:19 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d870016bfce8135c8b004c671697d091345463f0
      https://github.com/llvm/llvm-project/commit/d870016bfce8135c8b004c671697d091345463f0
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-05-05 (Tue, 05 May 2020)

  Changed paths:
    M clang-tools-extra/clangd/Headers.cpp
    M clang-tools-extra/clangd/Headers.h
    M clang-tools-extra/clangd/XRefs.cpp
    M clang-tools-extra/clangd/unittests/HeadersTests.cpp
    M clang-tools-extra/clangd/unittests/XRefsTests.cpp

  Log Message:
  -----------
  [clangd] Get rid of Inclusion::R

Summary:
This is only used by documentlink and go-to-definition. We are pushing
range detection logic from Inclusion creation to users. This would make using
stale preambles easier.

For document links we make use of the spelledtokens stored in tokenbuffers to
figure out file name range.

For go-to-def, we keep storing the line number we've seen the include directive.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79315




More information about the All-commits mailing list