[all-commits] [llvm/llvm-project] 4f8d97: [clang] Fix an uint32_t overflow in large preamble.

Haojian Wu via All-commits all-commits at lists.llvm.org
Tue May 5 01:37:35 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4f8d9722b4992272c0e1b33d57fc20bbd93269af
      https://github.com/llvm/llvm-project/commit/4f8d9722b4992272c0e1b33d57fc20bbd93269af
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2020-05-05 (Tue, 05 May 2020)

  Changed paths:
    M clang/include/clang/Serialization/ASTReader.h
    M clang/include/clang/Serialization/ASTRecordReader.h
    M clang/lib/Serialization/ASTReaderDecl.cpp

  Log Message:
  -----------
  [clang] Fix an uint32_t overflow in large preamble.

Summary:
I was surprised to see the LocalOffset can exceed uint32_t, but it
does happen and lead to crashes in one of our internal huge TU with a large
preamble.

with this patch, the crash is gone.

Reviewers: sammccall

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79397




More information about the All-commits mailing list