[all-commits] [llvm/llvm-project] ec170b: [clangd] Fix whitespace between chunks in markdown...

[Sam McCall via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ec170b7ccd5bf7aa05dea80e6f246964fd081e98
      https://github.com/llvm/llvm-project/commit/ec170b7ccd5bf7aa05dea80e6f246964fd081e98
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-05-02 (Sat, 02 May 2020)

  Changed paths:
    M clang-tools-extra/clangd/FormattedString.cpp
    M clang-tools-extra/clangd/FormattedString.h
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/FormattedStringTests.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Fix whitespace between chunks in markdown paragraphs.

Summary:
Old model: chunks are always separated by one space.
           This makes it impossible to render "Foo `bar`." correctly.

New model: chunks are separated by space if the left had trailing space, or
           the right had leading space, or space was explicitly requested.
           (Only leading/trailing space in plaintext chunks count, not code)

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D79139


  Commit: fa1f4cf84326b59f917bccde784875c742e71740
      https://github.com/llvm/llvm-project/commit/fa1f4cf84326b59f917bccde784875c742e71740
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-05-02 (Sat, 02 May 2020)

  Changed paths:
    M clang-tools-extra/clangd/CMakeLists.txt
    M clang-tools-extra/clangd/ClangdLSPServer.cpp
    M clang-tools-extra/clangd/ClangdServer.cpp
    M clang-tools-extra/clangd/ClangdServer.h
    M clang-tools-extra/clangd/CodeComplete.h
    R clang-tools-extra/clangd/FormattedString.cpp
    R clang-tools-extra/clangd/FormattedString.h
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/Hover.h
    M clang-tools-extra/clangd/XRefs.h
    M clang-tools-extra/clangd/support/CMakeLists.txt
    A clang-tools-extra/clangd/support/Markup.cpp
    A clang-tools-extra/clangd/support/Markup.h
    M clang-tools-extra/clangd/unittests/CMakeLists.txt
    R clang-tools-extra/clangd/unittests/FormattedStringTests.cpp
    A clang-tools-extra/clangd/unittests/support/MarkupTests.cpp

  Log Message:
  -----------
  [clangd] Rename FormattedString -> Markup, move to support. NFC


Compare: https://github.com/llvm/llvm-project/compare/030ff901f432...fa1f4cf84326