[all-commits] [llvm/llvm-project] 935079: [DebugInfo] Update loop metadata in stripNonLineTa...

[Vedant Kumar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9350792c6284560de5c7dff249601486bcbabe48
      https://github.com/llvm/llvm-project/commit/9350792c6284560de5c7dff249601486bcbabe48
  Author: Vedant Kumar <vsk at apple.com>
  Date:   2020-05-01 (Fri, 01 May 2020)

  Changed paths:
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/unittests/IR/DebugInfoTest.cpp

  Log Message:
  -----------
  [DebugInfo] Update loop metadata in stripNonLineTableDebugInfo

Summary:
Have stripNonLineTableDebugInfo() attach updated !llvm.loop metadata to
an instruction (instead of updating and then discarding the metadata).

This fixes "!dbg attachment points at wrong subprogram for function"
errors seen while archiving an iOS app.

It would be nice -- as a follow-up -- to catch this issue earlier,
perhaps by modifying the verifier to constrain where DILocations are
allowed. Any alternative suggestions appreciated.

rdar://61982466

Reviewers: aprantl, dsanders

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D79200