[all-commits] [llvm/llvm-project] 5d806e: [XCOFF] Clean-up enum use in BinaryFormat/XCOFF.h; ...

[Hubert Tong via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d806e254e81411698089761aa4b441882a86b07
      https://github.com/llvm/llvm-project/commit/5d806e254e81411698089761aa4b441882a86b07
  Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/XCOFF.h

  Log Message:
  -----------
  [XCOFF] Clean-up enum use in BinaryFormat/XCOFF.h; NFC

Summary:
This patch splits mostly unrelated size constants into separate
constexpr variables, sets explicit underlying types for the enumerations
to match the fields they are used for, and improves various comments.

This patch also replaces `<cname>` headers with `<name.h>` headers to
match the usage of the declared names as global namespace members in the
file.

Reviewers: jasonliu, DiggerLin, daltenty, sfertile

Reviewed By: jasonliu, sfertile

Differential Revision: https://reviews.llvm.org/D79136


  Commit: a3515ab8af8aa2db463def55ba6a477b24e64a54
      https://github.com/llvm/llvm-project/commit/a3515ab8af8aa2db463def55ba6a477b24e64a54
  Author: Hubert Tong <hubert.reinterpretcast at gmail.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M llvm/lib/MC/MCAsmInfoXCOFF.cpp
    M llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp

  Log Message:
  -----------
  [MC][Target][XCOFF] Consolidate MCAsmInfo XCOFF defaults; NFC

The setting of `MCAsmInfo` properties for XCOFF got split between
`MCAsmInfoXCOFF` and `PPCXCOFFMCAsmInfo`. Except for the properties that
are dependent on the target information being passed via the
constructor, the properties being set in `PPCXCOFFMCAsmInfo` had no
fundamental reason for being treated as specific for XCOFF on PowerPC.
Indeed, the property that might be considered more specific to PowerPC,
`NeedsFunctionDescriptors`, was set in `MCAsmInfoXCOFF`.

XCOFF being specific to PowerPC anyway, this patch consolidates the
setting of the properties into `MCAsmInfoXCOFF` except for the cases
that are dependent on the information provided via the
`PPCXCOFFMCAsmInfo` constructor.

This patch also reorders the assignments to the fields to match the
declaration order in `MCAsmInfo`.


Compare: https://github.com/llvm/llvm-project/compare/c5f7c039efe7...a3515ab8af8a