[all-commits] [llvm/llvm-project] 0d61dc: [mlir][EDSC] Make use of InsertGuard

[Nicolas Vasilache via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d61dcf606b823c9cee4f16e89a7a0839be4ba36
      https://github.com/llvm/llvm-project/commit/0d61dcf606b823c9cee4f16e89a7a0839be4ba36
  Author: Nicolas Vasilache <ntv at google.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/EDSC/FoldedIntrinsics.h
    M mlir/include/mlir/Dialect/Linalg/Transforms/CMakeLists.txt
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
    M mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp
    M mlir/lib/Dialect/Affine/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
    M mlir/lib/EDSC/Builders.cpp
    R mlir/test/Dialect/Linalg/matmul-to-vector.mlir
    M mlir/test/lib/DeclarativeTransforms/CMakeLists.txt
    R mlir/test/lib/DeclarativeTransforms/TestLinalgMatmulToVectorPatterns.td
    M mlir/test/lib/Transforms/CMakeLists.txt
    R mlir/test/lib/Transforms/TestLinalgMatmulToVector.cpp
    M mlir/tools/mlir-opt/mlir-opt.cpp

  Log Message:
  -----------
  [mlir][EDSC] Make use of InsertGuard

Summary:
This revision cleans up a layer of complexity in ScopedContext and uses InsertGuard instead of previously manual bookkeeping.
The method `getBuilder` is renamed to `getBuilderRef` and spurious copies of OpBuilder are tracked.

This results in some canonicalizations not happening anymore in the Linalg matmul to vector test. This test is retired because relying on DRRs for this has been shaky at best. The solution will be better support to write fused passes in C++ with more idiomatic pattern composition and application.

Differential Revision: https://reviews.llvm.org/D79208