[all-commits] [llvm/llvm-project] 21afed: [lldb/CMake] Use INSTALL_RPATH for tools and BUILD...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 21afeddfb25fbde260f84ee6ceaa61e761c1e48c
      https://github.com/llvm/llvm-project/commit/21afeddfb25fbde260f84ee6ceaa61e761c1e48c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M lldb/source/API/CMakeLists.txt
    M lldb/tools/lldb-test/CMakeLists.txt

  Log Message:
  -----------
  [lldb/CMake] Use INSTALL_RPATH for tools and BUILD_RPATH for unittests.

It seems like only the unittests are building with
BUILD_WITH_INSTALL_RPATH set to OFF. Of course when I did my last change
I only ran check-lldb-unit. Not sure why this difference exists, why
would you even install the unittest?

For the LLDB framework we do need different build and install RPATHs.
Currently that logic lives downstream. I plan to upstream that in the
near future. For now I'm just trying to make it possible to run the
test.


  Commit: 32c3224612d84ee7e65907795eaba505f5c90e7c
      https://github.com/llvm/llvm-project/commit/32c3224612d84ee7e65907795eaba505f5c90e7c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M lldb/include/lldb/API/SBCommandInterpreter.h
    M lldb/include/lldb/API/SBDebugger.h
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/source/API/SBCommandInterpreter.cpp
    M lldb/source/API/SBDebugger.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp

  Log Message:
  -----------
  [lldb/CommandInterpreter] Move everything into CommandInterpreterRunOptions

This implements Greg's suggestion from D78825 to include "auto handle
events" and "spawn thread" in CommandInterpreterRunOptions. This change
is in preparation for adding a new overload for RunCommandInterpreter
that takes only SBCommandInterpreterRunOptions and returns
SBCommandInterpreterRunResults.

Differential revision: https://reviews.llvm.org/D79108


Compare: https://github.com/llvm/llvm-project/compare/226489715cb8...32c3224612d8