[all-commits] [llvm/llvm-project] 2fd7d3: [libc++] Make the verify-support feature implicit

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fd7d364cd999c743b5bdefa7ee9e5630f3564ad
      https://github.com/llvm/llvm-project/commit/2fd7d364cd999c743b5bdefa7ee9e5630f3564ad
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.depr_in_cxx14.verify.cpp
    M libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
    M libcxx/test/libcxx/containers/associative/non_const_comparator.incomplete.verify.cpp
    M libcxx/test/libcxx/containers/associative/non_const_comparator.verify.cpp
    M libcxx/test/libcxx/containers/unord/non_const_comparator.incomplete.verify.cpp
    M libcxx/test/libcxx/containers/unord/non_const_comparator.verify.cpp
    M libcxx/test/libcxx/depr/depr.auto.ptr/auto.ptr/auto_ptr.depr_in_cxx11.verify.cpp
    M libcxx/test/libcxx/depr/depr.c.headers/no_fgetpos_fsetpos.verify.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.depr_in_cxx17.verify.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.verify.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.verify.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator_types.depr_in_cxx17.verify.cpp
    M libcxx/test/libcxx/depr/depr.default.allocator/allocator_void.depr_in_cxx17.verify.cpp
    M libcxx/test/libcxx/depr/depr.function.objects/adaptors.depr_in_cxx11.verify.cpp
    M libcxx/test/libcxx/diagnostics/enable_nodiscard.verify.cpp
    M libcxx/test/libcxx/diagnostics/enable_nodiscard_disable_after_cxx17.verify.cpp
    M libcxx/test/libcxx/diagnostics/enable_nodiscard_disable_nodiscard_ext.verify.cpp
    M libcxx/test/libcxx/diagnostics/nodiscard_aftercxx17.verify.cpp
    M libcxx/test/libcxx/diagnostics/nodiscard_extensions.verify.cpp
    M libcxx/test/libcxx/experimental/filesystem/deprecated.verify.cpp
    R libcxx/test/libcxx/selftest/newformat/convenience_substitutions/verify.sh.cpp
    A libcxx/test/libcxx/selftest/newformat/fail.cpp/lit.local.cfg
    M libcxx/test/libcxx/selftest/newformat/verify.cpp/no-diagnostics-unmarked.verify.cpp
    M libcxx/test/libcxx/selftest/newformat/verify.cpp/no-diagnostics.verify.cpp
    M libcxx/test/libcxx/selftest/newformat/verify.cpp/right-diagnostic.verify.cpp
    M libcxx/test/libcxx/selftest/newformat/verify.cpp/wrong-diagnostic.verify.cpp
    M libcxx/test/libcxx/thread/atomic.availability.verify.cpp
    M libcxx/test/libcxx/thread/barrier.availability.verify.cpp
    M libcxx/test/libcxx/thread/latch.availability.verify.cpp
    M libcxx/test/libcxx/thread/semaphore.availability.verify.cpp
    M libcxx/test/libcxx/thread/thread.lock/thread.lock.guard/nodiscard.verify.cpp
    M libcxx/test/libcxx/utilities/function.objects/func.wrap/depr_in_cxx03.verify.cpp
    M libcxx/test/std/containers/associative/map/map.access/empty.verify.cpp
    M libcxx/test/std/containers/associative/multimap/empty.verify.cpp
    M libcxx/test/std/containers/associative/multiset/empty.verify.cpp
    M libcxx/test/std/containers/associative/set/empty.verify.cpp
    M libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.members/empty.verify.cpp
    M libcxx/test/std/containers/container.adaptors/queue/queue.defn/empty.verify.cpp
    M libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.verify.cpp
    M libcxx/test/std/containers/sequences/array/empty.verify.cpp
    M libcxx/test/std/containers/sequences/deque/deque.capacity/empty.verify.cpp
    M libcxx/test/std/containers/sequences/forwardlist/empty.verify.cpp
    M libcxx/test/std/containers/sequences/list/list.capacity/empty.verify.cpp
    M libcxx/test/std/containers/sequences/vector.bool/empty.verify.cpp
    M libcxx/test/std/containers/sequences/vector/vector.capacity/empty.verify.cpp
    M libcxx/test/std/containers/sequences/vector/vector.cons/copy.move_only.verify.cpp
    M libcxx/test/std/containers/unord/unord.map/empty.verify.cpp
    M libcxx/test/std/containers/unord/unord.multimap/empty.verify.cpp
    M libcxx/test/std/containers/unord/unord.multiset/empty.verify.cpp
    M libcxx/test/std/containers/unord/unord.set/empty.verify.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.bind.1st/bind1st.depr_in_cxx11.verify.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.bind.2nd/bind2nd.depr_in_cxx11.verify.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.binder.1st/binder1st.depr_in_cxx11.verify.cpp
    M libcxx/test/std/depr/depr.lib.binders/depr.lib.binder.2nd/binder2nd.depr_in_cxx11.verify.cpp
    M libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/empty.verify.cpp
    M libcxx/test/std/iterators/iterator.container/empty.array.verify.cpp
    M libcxx/test/std/iterators/iterator.container/empty.container.verify.cpp
    M libcxx/test/std/iterators/iterator.container/empty.initializer_list.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_nothrow.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_array_ptr.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_ptr.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_nothrow.verify.cpp
    M libcxx/test/std/language.support/support.dynamic/ptr.launder/launder.nodiscard.verify.cpp
    M libcxx/test/std/re/re.results/re.results.size/empty.verify.cpp
    M libcxx/test/std/strings/basic.string/string.capacity/empty.verify.cpp
    M libcxx/test/std/strings/string.view/string.view.capacity/empty.verify.cpp
    M libcxx/test/std/thread/futures/futures.async/async.verify.cpp
    M libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size.verify.cpp
    M libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/allocate_size_hint.verify.cpp
    M libcxx/test/std/utilities/function.objects/negators/binary_negate.depr_in_cxx17.verify.cpp
    M libcxx/test/std/utilities/function.objects/negators/not1.depr_in_cxx17.verify.cpp
    M libcxx/test/std/utilities/function.objects/negators/not2.depr_in_cxx17.verify.cpp
    M libcxx/test/std/utilities/function.objects/negators/unary_negate.depr_in_cxx17.verify.cpp
    M libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/allocate.verify.cpp
    M libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.verify.cpp
    M libcxx/utils/libcxx/test/config.py
    M libcxx/utils/libcxx/test/format.py
    M libcxx/utils/libcxx/test/newformat.py

  Log Message:
  -----------
  [libc++] Make the verify-support feature implicit

Tests that require support for Clang-verify are already marked as such
explicitly by their extension, which is .verify.cpp. Requiring the use
of an explicit Lit feature is, after thought, not really helpful.

This is a change in design: we have been bitten in the past by tests not
being enabled when we thought they were. However, the issue was mostly
with file extensions being ignored. The fix for that is not to blindly
require explicit features all the time, but instead to report all files
that are in the suite but that don't match any known test format. This
can be implemented in a follow-up patch.