[all-commits] [llvm/llvm-project] 038325: [InlineCost] Addressing a very strict assert check...

KirillVNaumov via All-commits all-commits at lists.llvm.org
Thu Apr 30 08:39:23 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0383253cdfe705c83fff60a15fc6b3b71c41ee89
      https://github.com/llvm/llvm-project/commit/0383253cdfe705c83fff60a15fc6b3b71c41ee89
  Author: Kirill Naumov <knaumov at azul.com>
  Date:   2020-04-30 (Thu, 30 Apr 2020)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp
    A llvm/test/Transforms/Inline/print-instructions-deltas-unfinished.ll

  Log Message:
  -----------
  [InlineCost] Addressing a very strict assert check in CostAnnotationWriter::emitInstructionAnnot

The assert checks that every instruction must be annotated by this point while it is not
necessary. If the inlining process was interrupted because the threshold was reached, the rest
of the instructions would not be annotated which triggers the assert.
The added test shows the situation in which it can happen.
This is a recommit as the original commit fail due to the absence of REQUIRES: assert in the test.

Reviewed By: mtrofin
Differential Revision: https://reviews.llvm.org/D79107




More information about the All-commits mailing list