[all-commits] [llvm/llvm-project] ffd5e1: [NFCi] Iterative Outliner + clang-format refactoring.

Puyan Lotfi via All-commits all-commits at lists.llvm.org
Wed Apr 29 15:37:13 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ffd5e121d7444e93db02506b30719fd1df19a9f7
      https://github.com/llvm/llvm-project/commit/ffd5e121d7444e93db02506b30719fd1df19a9f7
  Author: Puyan Lotfi <puyan at puyan.org>
  Date:   2020-04-29 (Wed, 29 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/MachineOutliner.cpp
    A llvm/test/CodeGen/AArch64/machine-outliner-iterative-2.mir
    M llvm/test/CodeGen/AArch64/machine-outliner-iterative.mir

  Log Message:
  -----------
  [NFCi] Iterative Outliner + clang-format refactoring.

Prior to D69446 I had done some NFC cleanup to make landing an iterative
outliner a cleaner more straight-forward patch. Since then, it seems that has
landed but I noticed some ways it could be cleaned up. Specifically:

1) doOutline was meant to be the re-runable function, but instead
   runOnceOnModule was created that just calls doOutline.
2) In D69446 we discussed that the flag allowing the re-run of the
   outliner should be a flag to tell how many additional times to run
   the outliner again, not the total number of times. I don't think it
   makes sense to introduce a flag, but print an error if the flag is
   set to 0.

This is an NFCi, the i being that I get rid of the way that the
machine-outline-runs flag could be used to tell the outliner to not run
at all, and because I renamed the flag to '-machine-outliner-reruns'.

Differential Revision: https://reviews.llvm.org/D79070




More information about the All-commits mailing list