[all-commits] [llvm/llvm-project] 56a698: [mlir][Pass][NFC] Merge OpToOpPassAdaptor and OpTo...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 56a698510faef5bf3ef224c229a049bb1e376a56
      https://github.com/llvm/llvm-project/commit/56a698510faef5bf3ef224c229a049bb1e376a56
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-29 (Wed, 29 Apr 2020)

  Changed paths:
    M mlir/lib/Pass/IRPrinting.cpp
    M mlir/lib/Pass/Pass.cpp
    M mlir/lib/Pass/PassDetail.h
    M mlir/lib/Pass/PassStatistics.cpp
    M mlir/lib/Pass/PassTiming.cpp

  Log Message:
  -----------
  [mlir][Pass][NFC] Merge OpToOpPassAdaptor and OpToOpPassAdaptorParallel

This moves the threading check to runOnOperation. This produces a much cleaner interface for the adaptor pass, and will allow for the ability to enable/disable threading in a much cleaner way in the future.

Differential Revision: https://reviews.llvm.org/D78313


  Commit: 983382f134a83f51b4614ab4544ed093bcb52f5e
      https://github.com/llvm/llvm-project/commit/983382f134a83f51b4614ab4544ed093bcb52f5e
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-29 (Wed, 29 Apr 2020)

  Changed paths:
    M mlir/docs/PassManagement.md
    M mlir/include/mlir/Pass/Pass.h
    M mlir/include/mlir/Pass/PassManager.h
    M mlir/lib/Pass/Pass.cpp
    M mlir/lib/Pass/PassManagerOptions.cpp
    M mlir/test/Pass/crash-recovery.mlir

  Log Message:
  -----------
  [mlir][Pass] Add support for generating local crash reproducers

This revision adds a mode to the crash reproducer generator to attempt to generate a more local reproducer. This will attempt to generate a reproducer right before the offending pass that fails. This is useful for the majority of failures that are specific to a single pass, and situations where some passes in the pipeline are not registered with a specific tool.

Differential Revision: https://reviews.llvm.org/D78314


  Commit: e62ff42f79e5b59e3d1331ab9988528aae031a48
      https://github.com/llvm/llvm-project/commit/e62ff42f79e5b59e3d1331ab9988528aae031a48
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-29 (Wed, 29 Apr 2020)

  Changed paths:
    M mlir/lib/Pass/Pass.cpp

  Log Message:
  -----------
  [mlir][Pass] Register a signal handler when generating crash reproducers.

The current implementation uses CrashRecoveryContext, but this only supports recovering in a certain number of cases. This revision adds a signal handler to support even more situations.

This revision was able to properly generate a reproducer for a segfault in the Inliner, that the current recovery couldn't.

Differential Revision: https://reviews.llvm.org/D78315


Compare: https://github.com/llvm/llvm-project/compare/30d17d885283...e62ff42f79e5