[all-commits] [llvm/llvm-project] 66947d: [InlineCost] Addressing a very strict assert check...

[KirillVNaumov via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 66947d05fd193bb8948943a62455d617974f2012
      https://github.com/llvm/llvm-project/commit/66947d05fd193bb8948943a62455d617974f2012
  Author: Kirill Naumov <knaumov at azul.com>
  Date:   2020-04-29 (Wed, 29 Apr 2020)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp
    A llvm/test/Transforms/Inline/print-instructions-deltas-unfinished.ll

  Log Message:
  -----------
  [InlineCost] Addressing a very strict assert check in CostAnnotationWriter::emitInstructionAnnot

The assert checks that every instruction must be annotated by this point while it is not
necessary. If the inlining process was interrupted because the threshold was reached, the rest
of the instructions would not be annotated which triggers the assert.
The added test shows the situation in which it can happen.

Reviewed-By: mtrofin
Diff: https://reviews.llvm.org/D79107


  Commit: 055f58fcfc618cdad0a8cb66fbd4657cdc0d05e9
      https://github.com/llvm/llvm-project/commit/055f58fcfc618cdad0a8cb66fbd4657cdc0d05e9
  Author: Kirill Naumov <knaumov at azul.com>
  Date:   2020-04-29 (Wed, 29 Apr 2020)

  Changed paths:
    M llvm/lib/Analysis/CFGPrinter.cpp
    M llvm/test/Other/cfg_deopt_unreach.ll

  Log Message:
  -----------
  [CFG] Turning on Heat Colors for CFG by default

This option seems to be very useful, so let's turn it on by default

Reviewed-By: davidxl
Diff: https://reviews.llvm.org/D79110


Compare: https://github.com/llvm/llvm-project/compare/e071ea48e923...055f58fcfc61