[all-commits] [llvm/llvm-project] 837258: [lldb-vscode] Add an option for loading core files

[walter erquinigo via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 83725822c52535c239b1a7991023f96bfbc95568
      https://github.com/llvm/llvm-project/commit/83725822c52535c239b1a7991023f96bfbc95568
  Author: Walter Erquinigo <waltermelon at fb.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    A lldb/test/API/tools/lldb-vscode/coreFile/TestVSCode_coreFile.py
    A lldb/test/API/tools/lldb-vscode/coreFile/linux-x86_64.core
    A lldb/test/API/tools/lldb-vscode/coreFile/linux-x86_64.out
    M lldb/tools/lldb-vscode/README.md
    M lldb/tools/lldb-vscode/lldb-vscode.cpp
    M lldb/tools/lldb-vscode/package.json

  Log Message:
  -----------
  [lldb-vscode] Add an option for loading core files

Summary:
Currently loading core files on lldb-vscode is broken because there's a check in the attach workflow that asserts that the PID is valid, which of course fails for this case.
Hence, I'm adding a "coreFile" argument for the attach request, which does the work correctly.

I don't know how to test it effectively so that it runs on the buildbots and the debugger can in fact makes sense of it. Anyway, the change has been relatively simple.

Reviewers: labath, clayborg

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D78839