[all-commits] [llvm/llvm-project] 9ff3f3: [clangd] Fix remote index build without shared lib...

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Tue Apr 28 10:17:21 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9ff3f339e881b65217272cb11714493d0e5f1c70
      https://github.com/llvm/llvm-project/commit/9ff3f339e881b65217272cb11714493d0e5f1c70
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M clang-tools-extra/clangd/index/remote/server/CMakeLists.txt
    M llvm/cmake/modules/FindGRPC.cmake
    M llvm/cmake/modules/LLVMProcessSources.cmake

  Log Message:
  -----------
  [clangd] Fix remote index build without shared libs mode

Summary:
Generated Protobuf library has to be in CLANG_EXPORTS and should also be
installed appropriately. The easiest way to do that is via CMake's
add_clang_library. That unfortunately applies "one directory - one
clang_(library|tool)" policy so .proto files should be in a separate directory
and complicates the layout.

This setup works both in shared and static libs mode.

Resolves: https://github.com/clangd/clangd/issues/351

Reviewers: sammccall

Reviewed By: sammccall

Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits, llvm-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D78885




More information about the All-commits mailing list