[all-commits] [llvm/llvm-project] edb778: [mlir][assemblyFormat] Fix bug when using AttrSize...

[maerhart via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: edb77864ef7865437f425e98f2089e426a1ea8dc
      https://github.com/llvm/llvm-project/commit/edb77864ef7865437f425e98f2089e426a1ea8dc
  Author: Martin Erhart <maerhart at outlook.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M mlir/test/lib/Dialect/Test/TestOps.td
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with only non-buildable operand types

Summary:
When creating an operation with
* `AttrSizedOperandSegments` trait
* Variadic operands of only non-buildable types
* assemblyFormat to automatically generate the parser
the `builder` local variable is used, but never declared.
This adds a fix as well as a test for this case as existing ones use buildable types only.

Reviewers: rriddle, Kayjukh, grosser

Reviewed By: Kayjukh

Subscribers: mehdi_amini, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #mlir, #llvm

Differential Revision: https://reviews.llvm.org/D79004