[all-commits] [llvm/llvm-project] 7f8ae5: [mlir][assemblyFormat] Fix bug when using AttrSize...

[maerhart via All-commits]

  Branch: refs/heads/arcpatch-D79004
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f8ae5405a93a6041bd0969da7ccb288a4f7ec22
      https://github.com/llvm/llvm-project/commit/7f8ae5405a93a6041bd0969da7ccb288a4f7ec22
  Author: Martin Erhart <maerhart at outlook.com>
  Date:   2020-04-28 (Tue, 28 Apr 2020)

  Changed paths:
    M mlir/test/lib/Dialect/Test/TestOps.td
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][assemblyFormat] Fix bug when using AttrSizedOperandSegments trait with non-buildable operand types only

Summary:
When creating an operation with
* the `AttrSizedOperandSegments` trait
* variadic operands of only non-buildable types
* assemblyFormat to automatically generate the parser
a local `builder` variable is used, but never declared.
This adds a fix as well as a test for this case, as existing ones use buildable
types only.

Reviewers: rriddle, Kayjukh, grosser

Reviewed By: Kayjukh

Subscribers: mehdi_amini, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #mlir, #llvm

Differential Revision: https://reviews.llvm.org/D79004