[all-commits] [llvm/llvm-project] 2d2d69: [MLIR] Propagate input side effect information

[Tres via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d2d696137d729dcd2d83330e4d3b9e305f96640
      https://github.com/llvm/llvm-project/commit/2d2d696137d729dcd2d83330e4d3b9e305f96640
  Author: Tres Popp <tpopp at google.com>
  Date:   2020-04-27 (Mon, 27 Apr 2020)

  Changed paths:
    M mlir/include/mlir/Interfaces/SideEffects.td
    M mlir/include/mlir/Support/LLVM.h
    M mlir/include/mlir/TableGen/OpClass.h
    M mlir/include/mlir/TableGen/SideEffects.h
    M mlir/lib/TableGen/OpClass.cpp
    M mlir/lib/TableGen/SideEffects.cpp
    M mlir/test/Conversion/StandardToSPIRV/legalization.mlir
    M mlir/test/Conversion/VectorToLoops/vector-to-loops.mlir
    M mlir/test/Dialect/Affine/canonicalize.mlir
    M mlir/test/Dialect/GPU/all-reduce-max.mlir
    M mlir/test/Dialect/GPU/all-reduce.mlir
    M mlir/test/Dialect/Linalg/loops.mlir
    M mlir/test/Dialect/Linalg/parallel_loops.mlir
    M mlir/test/Transforms/canonicalize.mlir
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [MLIR] Propagate input side effect information

Summary:
Previously operations like std.load created methods for obtaining their
effects but did not inherit from the SideEffect interfaces when their
parameters were decorated with the information. The resulting situation
was that passes had no information on the SideEffects of std.load/store
and had to treat them more cautiously. This adds the inheritance
information when creating the methods.

As a side effect, many tests are modified, as they were using std.load
for testing and this oepration would be folded away as part of pattern
rewriting. Tests are modified to use store or to reutn the result of the
std.load.

Reviewers: mravishankar, antiagainst, nicolasvasilache, herhut, aartbik, ftynse!

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, csigg, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, bader, grosul1, frgossen, Kayjukh, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78802