[all-commits] [llvm/llvm-project] 09684b: llvm: IPO: handle IRMover error handling, bug #45636

Sergei Trofimovich via All-commits all-commits at lists.llvm.org
Sat Apr 25 11:16:17 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 09684b08d3b56b8ab0adb8fe46f709aeba29cee6
      https://github.com/llvm/llvm-project/commit/09684b08d3b56b8ab0adb8fe46f709aeba29cee6
  Author: Sergei Trofimovich <slyfox at inbox.ru>
  Date:   2020-04-25 (Sat, 25 Apr 2020)

  Changed paths:
    M llvm/lib/Transforms/IPO/FunctionImport.cpp

  Log Message:
  -----------
  llvm: IPO: handle IRMover error handling, bug #45636

Summary:
Missing error mangling is noticed in
https://bugs.llvm.org/show_bug.cgi?id=45636
where inconsistent profiling input caused
llvm/lld to crash as:

```
Program aborted due to an unhandled Error:
linking module flags 'ProfileSummary':
  IDs have conflicting values in 'Mutex_posix.o' and 'nsBrowserApp.o'
```

The change does not change the fact that LLVM crashes
but changes error output to say what was incorrect:

```
LLVM ERROR: Function Import: link error:
  linking module flags 'ProfileSummary':
    IDs have conflicting values in 'Mutex_posix.o' and 'nsBrowserApp.o'
```

Actual crash has yet to be fixed.

Reviewers: lattner

Reviewed By: lattner

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78676




More information about the All-commits mailing list