[all-commits] [llvm/llvm-project] 485cf1: Define SDBM key methods in its own cpp file.

Stella Laurenzo via All-commits all-commits at lists.llvm.org
Fri Apr 24 19:10:04 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 485cf19651a5710159493e678835ba02a3fc21cb
      https://github.com/llvm/llvm-project/commit/485cf19651a5710159493e678835ba02a3fc21cb
  Author: Stella Laurenzo <stellaraccident at gmail.com>
  Date:   2020-04-24 (Fri, 24 Apr 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/SDBM/SDBMDialect.h
    M mlir/lib/Dialect/SDBM/CMakeLists.txt
    A mlir/lib/Dialect/SDBM/SDBMDialect.cpp

  Log Message:
  -----------
  Define SDBM key methods in its own cpp file.

Summary:
* Follows the convention of the tablegen-generated dialects.
* Ensures that vague linkage rules place the definitions in the dialect's object files.
* Allows code that uses RTTI to include MLIR headers (compiled without RTTI) without
  type_info link errors.

Reviewers: rriddle

Reviewed By: rriddle

Subscribers: mgorny, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78039




More information about the All-commits mailing list