[all-commits] [llvm/llvm-project] 0e2bd4: [mlir][DictionaryAttr] Add a new getWithSorted and...

River Riddle via All-commits all-commits at lists.llvm.org
Fri Apr 24 12:24:18 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e2bd49370197dd8bf2c36ee0ce1275f7cfb515b
      https://github.com/llvm/llvm-project/commit/0e2bd49370197dd8bf2c36ee0ce1275f7cfb515b
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-24 (Fri, 24 Apr 2020)

  Changed paths:
    M mlir/include/mlir/IR/Attributes.h
    M mlir/lib/IR/Attributes.cpp

  Log Message:
  -----------
  [mlir][DictionaryAttr] Add a new getWithSorted and use it when possible

The elements of a DictionaryAttr are sorted by name. In many situations, e.g NamedAttributeList, we can guarantee that the elements are sorted on construction and remove the need to perform extra checks. In places with lots of calls to attribute methods, this leads to a good performance improvement.

Differential Revision: https://reviews.llvm.org/D78781




More information about the All-commits mailing list