[all-commits] [llvm/llvm-project] bd6942: Re-land "[MS] Fix assert handling enum forward dec...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Thu Apr 23 16:27:27 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581
      https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-04-23 (Thu, 23 Apr 2020)

  Changed paths:
    M clang/lib/Sema/SemaType.cpp
    A clang/test/Modules/Inputs/ms-enums/A.h
    A clang/test/Modules/Inputs/ms-enums/B.h
    A clang/test/Modules/Inputs/ms-enums/module.map
    A clang/test/Modules/ms-enums.cpp

  Log Message:
  -----------
  Re-land "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"

This reverts commit 9b2ab41037f45ad92ab4e850591093ffc45d3e10 and
reinstates e62dc1f6252c1dcdcc2a64e8e3b07a32412e9d89 with changes.

This fix is speculative, since I don't have access to a crashing test
case for the old code, and fixing the crash bug on Windows when C++20 is
enabled seems more important than running it down.




More information about the All-commits mailing list