[all-commits] [llvm/llvm-project] 367229: [mlir][EDSC] Retire ValueHandle

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Thu Apr 23 08:05:13 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 367229e100eca714276253bf95a0dd3d084a9624
      https://github.com/llvm/llvm-project/commit/367229e100eca714276253bf95a0dd3d084a9624
  Author: Nicolas Vasilache <ntv at google.com>
  Date:   2020-04-23 (Thu, 23 Apr 2020)

  Changed paths:
    M mlir/docs/Dialects/Linalg.md
    M mlir/docs/EDSC.md
    M mlir/include/mlir/Dialect/Affine/EDSC/Builders.h
    M mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
    M mlir/include/mlir/Dialect/Linalg/EDSC/FoldedIntrinsics.h
    M mlir/include/mlir/Dialect/LoopOps/EDSC/Builders.h
    M mlir/include/mlir/Dialect/StandardOps/EDSC/Builders.h
    M mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
    M mlir/include/mlir/Dialect/Vector/EDSC/Intrinsics.h
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/include/mlir/EDSC/Intrinsics.h
    M mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp
    M mlir/lib/Dialect/Affine/EDSC/Builders.cpp
    M mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp
    M mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
    M mlir/lib/Dialect/LoopOps/EDSC/Builders.cpp
    M mlir/lib/Dialect/StandardOps/EDSC/Builders.cpp
    M mlir/lib/Dialect/StandardOps/EDSC/Intrinsics.cpp
    M mlir/lib/EDSC/Builders.cpp
    M mlir/test/EDSC/builder-api-test.cpp
    M mlir/test/mlir-linalg-ods-gen/test-linalg-ods-gen.tc
    M mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp

  Log Message:
  -----------
  [mlir][EDSC] Retire ValueHandle

The EDSC discussion [thread](https://llvm.discourse.group/t/evolving-builder-apis-based-on-lessons-learned-from-edsc/879) points out that ValueHandle has become an unnecessary level of abstraction since MLIR switch from `Value *` to `Value` everywhere.

This revision removes this level of indirection.




More information about the All-commits mailing list