[all-commits] [llvm/llvm-project] 932125: [lldb/Core] Avoid more Communication::Disconnect r...

Pavel Labath via All-commits all-commits at lists.llvm.org
Thu Apr 23 07:36:43 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9321255b8825d9165b2884204348a353af36d212
      https://github.com/llvm/llvm-project/commit/9321255b8825d9165b2884204348a353af36d212
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-04-23 (Thu, 23 Apr 2020)

  Changed paths:
    M lldb/source/Core/Communication.cpp
    M lldb/source/Target/Process.cpp

  Log Message:
  -----------
  [lldb/Core] Avoid more Communication::Disconnect races

Calling Disconnect while the read thread is running is racy because the
thread can also call Disconnect.  This is a follow-up to b424b0bf, which
reorders other occurences of Disconnect/StopReadThread I can find, and also
adds an assertion to guard against new occurences being introduced.




More information about the All-commits mailing list