[all-commits] [llvm/llvm-project] e5291c: [libc++/abi] Provide an option to turn on forgivin...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Apr 22 13:25:40 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e5291c4ae3f7272ca3901d1189d30e23fd578193
      https://github.com/llvm/llvm-project/commit/e5291c4ae3f7272ca3901d1189d30e23fd578193
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-22 (Wed, 22 Apr 2020)

  Changed paths:
    M libcxx/cmake/caches/Apple.cmake
    M libcxxabi/CMakeLists.txt
    M libcxxabi/src/CMakeLists.txt
    M libcxxabi/src/private_typeinfo.cpp

  Log Message:
  -----------
  [libc++/abi] Provide an option to turn on forgiving dynamic_cast when building libc++abi

Instead of the ad-hoc #define _LIBCXX_DYNAMIC_FALLBACK, provide an option
to enable the setting when building libc++abi. Also use the occasion to
rename the option to something slightly more descriptive.

Note that in the future, it would be great to simply remove this option
altogether. However, in the meantime, it seems better to have it be an
official option than something ad-hoc.




More information about the All-commits mailing list