[all-commits] [llvm/llvm-project] 46a52f: [TargetPassConfig] Run MachineVerifier after more ...

Eli Friedman via All-commits all-commits at lists.llvm.org
Tue Apr 21 21:05:58 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 46a52ff9eda0750ff05311310774d954bcaf3408
      https://github.com/llvm/llvm-project/commit/46a52ff9eda0750ff05311310774d954bcaf3408
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/TargetPassConfig.cpp

  Log Message:
  -----------
  [TargetPassConfig] Run MachineVerifier after more passes.

We were disabling verification for no reason in a bunch of places; just
turn it on.

At this point, there are two key places where we don't run verification:
during register allocation, and after addPreEmitPass.  Regalloc probably
isn't worth messing with; it has its own invariants, and verifying
afterwards is probably good enough.  For after addPreEmitPass, it's
probably worth investigating improvements.




More information about the All-commits mailing list