[all-commits] [llvm/llvm-project] d892ee: Reapply: Make header inclusion order from umbrella...

[Bruno Cardoso Lopes via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d892eec710caae84099f38fdb89d32ca15a23c1a
      https://github.com/llvm/llvm-project/commit/d892eec710caae84099f38fdb89d32ca15a23c1a
  Author: Bruno Cardoso Lopes <bruno.cardoso at gmail.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M clang/lib/Frontend/FrontendAction.cpp

  Log Message:
  -----------
  Reapply: Make header inclusion order from umbrella dirs deterministic

Sort the headers by name before adding the includes in
collectModuleHeaderIncludes. This makes the include order for building
umbrellas deterministic across different filesystems and also guarantees
that the ASTWriter always dump top headers in the same order.

There's currently no good way to test for this behavior.

This was first introduced in r289478 and reverted few times because of
ASANifed test failures on open source bots (both from LLVM and Swift).

Finally reproduced the problem in a Linux machine and use std::sort as a
fix, since we are not dealing with POD-like types.

rdar://problem/28116411