[all-commits] [llvm/llvm-project] 400b6f: [lldb/Test] Add skipIfReproducer for tests that ar...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Tue Apr 21 14:42:53 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 400b6f2bc53915b61f1ed9408819fa898e4c8941
      https://github.com/llvm/llvm-project/commit/400b6f2bc53915b61f1ed9408819fa898e4c8941
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
    M lldb/test/API/functionalities/inferior-changed/TestInferiorChanged.py
    M lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py

  Log Message:
  -----------
  [lldb/Test] Add skipIfReproducer for tests that are not expected to work

Some tests are not expected to work with reproducers, for example tests
that completely circumvent the reproducers (i.e. using the side_effects
Python module) or that rely on changes to the file system.


  Commit: 1e566f6b47fb77812d99c93e0a1b8613d288058c
      https://github.com/llvm/llvm-project/commit/1e566f6b47fb77812d99c93e0a1b8613d288058c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M lldb/test/API/commands/command/script/TestCommandScript.py
    M lldb/test/API/commands/expression/issue_11588/Test11588.py
    M lldb/test/API/commands/process/attach-resume/TestAttachResume.py
    M lldb/test/API/commands/process/attach/TestProcessAttach.py
    M lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
    M lldb/test/API/functionalities/conditional_break/TestConditionalBreak.py
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M lldb/test/API/functionalities/signal/TestSendSignal.py
    M lldb/test/API/functionalities/step_scripted/TestStepScripted.py
    M lldb/test/API/lang/objc/foundation/TestRuntimeTypes.py
    M lldb/test/API/lang/objc/modules/TestObjCModules.py
    M lldb/test/API/lang/objc/print-obj/TestPrintObj.py
    M lldb/test/API/python_api/hello_world/TestHelloWorld.py

  Log Message:
  -----------
  [lldb/Test] Add skipIfReproducer for tests that diverge during replay

Add the skipIfReproducer decorator to the remaining tests that fail to
replay because the GDB remote packets diverge during replay. This is
*not* expected and should be fixed, but figuring out exactly what caused
the divergence has proven pretty difficult to track down.

I've marked these tests as skipped for now so we can get clean results
and detect new regressions. I have no evidence to believe that these
failures have the same root cause, so I've not assigned them a PR.


Compare: https://github.com/llvm/llvm-project/compare/67c6b80569b0...1e566f6b47fb


More information about the All-commits mailing list