[all-commits] [llvm/llvm-project] 0535fa: [Flang][test] Don't set PATH in flang/test/Semanti...

[rorth via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0535fab2375ef71302bc0cf8e5d2ee3280b81f7d
      https://github.com/llvm/llvm-project/commit/0535fab2375ef71302bc0cf8e5d2ee3280b81f7d
  Author: Rainer Orth <ro at CeBiTec.Uni-Bielefeld.DE>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M flang/test/Semantics/common.sh

  Log Message:
  -----------
  [Flang][test] Don't set PATH in flang/test/Semantics/common.sh

Currently, many `Flang :: Semantics` tests FAIL on Solaris.  The failure
mode is always the same:

  actual at 67: Name in ALLOCATE statement must be a variable name
  expect at 67: ERROR: Name in ALLOCATE statement must be a variable name

It turns out the issue is twofold here:

- The awk script embedded in `flang/test/Semantics/common.sh` uses a string
  value for `FS`, which isn't supported by traditional awk as documented in
  the GNU autoconf manual.

- Even though /usr/gnu/bin (with gawk installed as awk) is in my build
  environment's `PATH`, still /bin/awk is used

Although the proper fix would probably be to avoid the unportability, it's
easy to work around it for now.  `common.sh` above is the only script in
the whole tree that for unknown reasons overrides `PATH` to
`/usr/bin:/bin`, unnecessarily creating this mess in the first place.  Just
removing that setting easily avoids the issue.

Tested on `amd64-pc-solaris2.11` and `sparcv9-sun-solaris2.11`.

Differential Revision: https://reviews.llvm.org/D78550