[all-commits] [llvm/llvm-project] 6e0171: [clangd] Store ppdirective in Inclusion

[kadir çetinkaya via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e017188b7607eb0f0b248881319bfd803cb8f78
      https://github.com/llvm/llvm-project/commit/6e017188b7607eb0f0b248881319bfd803cb8f78
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M clang-tools-extra/clangd/Headers.cpp
    M clang-tools-extra/clangd/Headers.h
    M clang-tools-extra/clangd/unittests/HeadersTests.cpp

  Log Message:
  -----------
  [clangd] Store ppdirective in Inclusion

Summary:
This will enable PreamblePatching proposed in D77392 craft a more
informed patch.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78235


  Commit: 2214b9076f1d3a4784820c4479e2417685e5c980
      https://github.com/llvm/llvm-project/commit/2214b9076f1d3a4784820c4479e2417685e5c980
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M clang-tools-extra/clangd/ClangdServer.cpp
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/Preamble.cpp
    M clang-tools-extra/clangd/Preamble.h
    M clang-tools-extra/clangd/TUScheduler.cpp
    M clang-tools-extra/clangd/TUScheduler.h
    M clang-tools-extra/clangd/unittests/CMakeLists.txt
    M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
    A clang-tools-extra/clangd/unittests/PreambleTests.cpp
    M clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
    M clang/include/clang/Basic/TokenKinds.h
    M clang/include/clang/Frontend/PrecompiledPreamble.h

  Log Message:
  -----------
  [clangd] Make signatureHelp work with stale preambles

Summary:
This is achieved by calculating newly added includes and implicitly
parsing them as if they were part of the main file.

This also gets rid of the need for consistent preamble reads.

Reviewers: sammccall

Subscribers: ilya-biryukov, javed.absar, MaskRay, jkorous, mgrang, arphaman, jfb, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D77392


Compare: https://github.com/llvm/llvm-project/compare/ee959ddc5eee...2214b9076f1d