[all-commits] [llvm/llvm-project] 4b03dd: PR45534: don't ignore unmodeled side-effects when ...

[Richard Smith via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b03dd7b849e8f5068dc8d72c6eab724c22a2805
      https://github.com/llvm/llvm-project/commit/4b03dd7b849e8f5068dc8d72c6eab724c22a2805
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-04-20 (Mon, 20 Apr 2020)

  Changed paths:
    M clang/lib/AST/ExprConstant.cpp
    M clang/test/SemaCXX/builtin-constant-p.cpp

  Log Message:
  -----------
  PR45534: don't ignore unmodeled side-effects when constant-evaluating a call to __builtin_constant_p.

Such side-effects should result in the call evaluating to 'false', even
if we can still determine what value the argument expression will
evaluate to.


  Commit: e128f710ea871bab5ed14b1944caa935ed61b003
      https://github.com/llvm/llvm-project/commit/e128f710ea871bab5ed14b1944caa935ed61b003
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-04-20 (Mon, 20 Apr 2020)

  Changed paths:
    M clang/lib/AST/Expr.cpp
    M clang/test/CodeGenCXX/builtin-constant-p.cpp

  Log Message:
  -----------
  PR45535: Check for variables with non-trivial destruction when
determining whether a statement expression has side-effects.


Compare: https://github.com/llvm/llvm-project/compare/b14e9e3c0cab...e128f710ea87