[all-commits] [llvm/llvm-project] 6afa5c: [lldb] Prefer executable files from sysroot over f...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6afa5c407c1330efcadb75b8f85993660bf275a7
      https://github.com/llvm/llvm-project/commit/6afa5c407c1330efcadb75b8f85993660bf275a7
  Author: Yuri Per <yuri at acronis.com>
  Date:   2020-04-20 (Mon, 20 Apr 2020)

  Changed paths:
    M lldb/source/Target/RemoteAwarePlatform.cpp
    M lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
    M lldb/test/API/functionalities/postmortem/elf-core/linux-x86_64.core

  Log Message:
  -----------
  [lldb] Prefer executable files from sysroot over files from local filesystem

Summary:
In D49685 sysroot behaviour was partially fixed. But files from local filesystem with same path still has priority over files from sysroot.

This patch fixes it by removing fallback to local filesystem from RemoteAwarePlatform::GetModuleSpec(). It is not actually required because higher level code do such fallback itself. See, for example, resolver in Platform::GetSharedModule().

Reviewers: labath, clayborg, EugeneBi

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77529


  Commit: 9cd9f3f1b8b7bfd30f7140c4c0006be5cead3e9a
      https://github.com/llvm/llvm-project/commit/9cd9f3f1b8b7bfd30f7140c4c0006be5cead3e9a
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-04-20 (Mon, 20 Apr 2020)

  Changed paths:
    M lldb/source/DataFormatters/TypeCategory.cpp

  Log Message:
  -----------
  [lldb] Fix gcc warnings in TypeCategory.cpp

The cleanup in 3e3701f8a0bf left these variable unused.


Compare: https://github.com/llvm/llvm-project/compare/fc6453974980...9cd9f3f1b8b7