[all-commits] [llvm/llvm-project] a348de: [CMake][NFC] Clean up CheckAtomic.cmake
Luís Marques via All-commits
all-commits at lists.llvm.org
Sat Apr 18 04:53:56 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: a348de480d34257ffe394ab51b880c9aef243d80
https://github.com/llvm/llvm-project/commit/a348de480d34257ffe394ab51b880c9aef243d80
Author: Luís Marques <luismarques at lowrisc.org>
Date: 2020-04-18 (Sat, 18 Apr 2020)
Changed paths:
M llvm/cmake/modules/CheckAtomic.cmake
Log Message:
-----------
[CMake][NFC] Clean up CheckAtomic.cmake
`CheckAtomic.cmake` was skipping the test of whether atomics work in MSVC
without an atomics library (they do), but not setting the value of
`HAVE_CXX_ATOMICS_WITHOUT_LIB`. That caused build issues when trying to land
D69869. I fixed that issue in f128f442a3d, by adding an `elseif(MSVC)`, as
was being done below in the 64-bit atomics check. That minimal fix did work,
but it kept various inconsistencies between the original atomics check and
the 64-bit one. This patch now makes the checks follow the same structure,
cleaning them up.
Differential Revision: https://reviews.llvm.org/D74767
More information about the All-commits
mailing list