[all-commits] [llvm/llvm-project] 239093: [lldb] [testsuite] Fix a regression of TestCppScop...

[Jan Kratochvil via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 239093f30c342bc8a3feec1536a3154e394e55ca
      https://github.com/llvm/llvm-project/commit/239093f30c342bc8a3feec1536a3154e394e55ca
  Author: Jan Kratochvil <jan.kratochvil at redhat.com>
  Date:   2020-04-18 (Sat, 18 Apr 2020)

  Changed paths:
    M lldb/test/API/lang/cpp/scope/TestCppScope.py

  Log Message:
  -----------
  [lldb] [testsuite] Fix a regression of TestCppScope.py

This is a regression since:
  [lldb][NFC] Modernize lang/cpp/scope test
  acb0b99c8e4f1dc65a7f1e26da9db77239a67da7
  rGacb0b99c8e4f

  File "/home/jkratoch/redhat/llvm-monorepo/lldb/test/API/lang/cpp/scope/TestCppScope.py", line 19, in test
    self.assertEqual(global_var_names, expected_var_names)
  AssertionError: Lists differ: ['C::a', 'A::a', 'B::a', '::a'... != ['A::a', 'B::a', 'C::a', '::a'...
  First differing element 0:
  C::a
  A::a
  - ['C::a', 'A::a', 'B::a', '::a']
  + ['A::a', 'B::a', 'C::a', '::a']

ManualDWARFIndex using NameToDIE does not sort alphabetically:
    // This is only for uniqueness, not lexicographical ordering, so we can
    // just compare pointers.
    return uintptr_t(lhs.GetCString()) < uintptr_t(rhs.GetCString());