[all-commits] [llvm/llvm-project] fd7a34: [Fixed Point] Move the compassign LHS type correct...

Bevin Hansson via All-commits all-commits at lists.llvm.org
Fri Apr 17 01:12:28 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fd7a34186137168064ffe2ca536823559b92d939
      https://github.com/llvm/llvm-project/commit/fd7a34186137168064ffe2ca536823559b92d939
  Author: Bevin Hansson <bevin.hansson at ericsson.com>
  Date:   2020-04-17 (Fri, 17 Apr 2020)

  Changed paths:
    M clang/lib/Sema/SemaExpr.cpp

  Log Message:
  -----------
  [Fixed Point] Move the compassign LHS type correction a bit further down. NFCI.

Summary:
We can simplify the LHSTy correction for
fixed-point compassign by moving it below
the point where we know we have a compound
assignment.

Also, we shouldn't look at the LHS and RHS
separately; look at the computation result
type instead.

Looking at the LHS and RHS is also wrong
for compassigns with fixed and floating
point (though this does not work upstream
yet).

Reviewers: leonardchan

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D78294




More information about the All-commits mailing list