[all-commits] [llvm/llvm-project] cc6e51: add release notes for ffp-model and ffp-exception-...

Alexandre Ganea via All-commits all-commits at lists.llvm.org
Thu Apr 16 12:05:51 PDT 2020


  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: cc6e51a1414989ff1c2dcab30c00ac10ea19afa1
      https://github.com/llvm/llvm-project/commit/cc6e51a1414989ff1c2dcab30c00ac10ea19afa1
  Author: Melanie Blower <melanie.blower at intel.com>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    M clang/docs/ReleaseNotes.rst

  Log Message:
  -----------
  add release notes for ffp-model and ffp-exception-behavior

(cherry picked from commit c8dadac228b7dd3a71d5fc25489d1b884a2b0f5e)


  Commit: 6196695ec5819c0df7efe3fecca5c4ef9ea80b1c
      https://github.com/llvm/llvm-project/commit/6196695ec5819c0df7efe3fecca5c4ef9ea80b1c
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2020-04-16 (Thu, 16 Apr 2020)

  Changed paths:
    A lld/test/COFF/pdb-tpi-aligned-records.test
    M llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
    M llvm/lib/DebugInfo/CodeView/MergingTypeTableBuilder.cpp
    M llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
    M llvm/lib/DebugInfo/PDB/Native/TpiStreamBuilder.cpp

  Log Message:
  -----------
  [CodeView] Align type records on 4-bytes when emitting PDBs

When emitting PDBs, the TypeStreamMerger class is used to merge .debug$T records from the input .OBJ files into the output .PDB stream.
Records in .OBJs are not required to be aligned on 4-bytes, and "The Netwide Assembler 2.14" generates non-aligned records.

When compiling with -DLLVM_ENABLE_ASSERTIONS=ON, an assert was triggered in MergingTypeTableBuilder when non-ghash merging was used.
With ghash merging there was no assert.
As a result, LLD could potentially generate a non-aligned TPI stream.

We now align records on 4-bytes when record indices are remapped, in TypeStreamMerger::remapIndices().

Differential Revision: https://reviews.llvm.org/D75081

(cherry picked from commit a7325298e1f311b383b8ce5ba8e2d3698fef472a)


Compare: https://github.com/llvm/llvm-project/compare/ef7dbe6de65b...6196695ec581


More information about the All-commits mailing list