[all-commits] [llvm/llvm-project] 937025: [CallGraphUpdater] Remove nodes from their SCC (ol...

[Johannes Doerfert via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 937025757c871c6caa62ec1858390a340e3ab526
      https://github.com/llvm/llvm-project/commit/937025757c871c6caa62ec1858390a340e3ab526
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M llvm/include/llvm/Analysis/CallGraphSCCPass.h
    M llvm/lib/Analysis/CallGraphSCCPass.cpp
    M llvm/lib/Transforms/Utils/CallGraphUpdater.cpp
    M llvm/unittests/IR/LegacyPassManagerTest.cpp

  Log Message:
  -----------
  [CallGraphUpdater] Remove nodes from their SCC (old PM)

Summary:
We can and should remove deleted nodes from their respective SCCs. We
did not do this before and this was a potential problem even though I
couldn't locally trigger an issue. Since the `DeleteNode` would assert
if the node was not in the SCC, we know we only remove nodes from their
SCC and only once (when run on all the Attributor tests).

Reviewers: lebedev.ri, hfinkel, fhahn, probinson, wristow, loladiro, sstefan1, uenoku

Subscribers: hiraditya, bollu, uenoku, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77855