[all-commits] [llvm/llvm-project] 122c50: Fix DWARFDataExtractor::getRelocatedValue near EOF

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Apr 15 03:48:34 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 122c50d5efc2d5bc8d6716a532ba0cc6b773ab3a
      https://github.com/llvm/llvm-project/commit/122c50d5efc2d5bc8d6716a532ba0cc6b773ab3a
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDataExtractor.cpp
    M llvm/unittests/DebugInfo/DWARF/DWARFDataExtractorTest.cpp

  Log Message:
  -----------
  Fix DWARFDataExtractor::getRelocatedValue near EOF

Summary:
If we have an (invalid) relocation which relocates bytes which partially
lie outside the range of the relocated section, the getRelocatedValue
would return confusing results. It would first read zero (because that's
what the underlying DataExtractor api does for out-of-bounds reads), and
then relocate that zero anyway.

A more appropriate behavior is to return zero straight away. This is
what this patch does.

Reviewers: dblaikie, jhenderson

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78113


  Commit: ff18a6acea318f739ced2a1d35a39cb874d2be91
      https://github.com/llvm/llvm-project/commit/ff18a6acea318f739ced2a1d35a39cb874d2be91
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M lldb/source/Target/ThreadPlanStack.cpp

  Log Message:
  -----------
  [lldb] Fix -Wparentheses in ThreadPlanStack.cpp


Compare: https://github.com/llvm/llvm-project/compare/cf9ee49b4d7f...ff18a6acea31


More information about the All-commits mailing list