[all-commits] [llvm/llvm-project] 129cf8: [mlir] LLVM dialect: support globals without linka...

[ftynse via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 129cf84e69537ae5c184550f94be18da738d9261
      https://github.com/llvm/llvm-project/commit/129cf84e69537ae5c184550f94be18da738d9261
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M mlir/docs/Dialects/LLVM.md
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/test/Dialect/LLVMIR/global.mlir

  Log Message:
  -----------
  [mlir] LLVM dialect: support globals without linkage keyword, assuming 'external'

Similarly to actual LLVM IR, and to `llvm.mlir.func`, allow the custom syntax
of `llvm.mlir.global` to omit the linkage keyword. If omitted, the linkage is
assumed to be external. This makes the modeling of globals in the LLVM dialect
more consistent, both within the dialect and with LLVM IR.

Differential Revision: https://reviews.llvm.org/D78096