[all-commits] [llvm/llvm-project] 3e3701: [lldb][NFC] Remove FormatterChoiceCriterion

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e3701f8a0bfafdbca91d4a9cae56c69242c754c
      https://github.com/llvm/llvm-project/commit/3e3701f8a0bfafdbca91d4a9cae56c69242c754c
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M lldb/include/lldb/DataFormatters/FormatClasses.h
    M lldb/include/lldb/DataFormatters/FormatManager.h
    M lldb/include/lldb/DataFormatters/FormattersContainer.h
    M lldb/include/lldb/DataFormatters/TypeCategory.h
    M lldb/include/lldb/lldb-private-enumerations.h
    M lldb/source/DataFormatters/FormatManager.cpp
    M lldb/source/DataFormatters/TypeCategory.cpp
    M lldb/source/DataFormatters/TypeCategoryMap.cpp

  Log Message:
  -----------
  [lldb][NFC] Remove FormatterChoiceCriterion

Summary:
The formatters code has a lot of 'reason' or 'why' values that we keep or-ing FormatterChoiceCriterion
enum values into. These values are only read by a single log statement and don't have any functional
purpose. It also seems the implementation is not finished (for example, display names and type
names don't have any dedicated enum values). Also everything is of course not tested or documented.

Let's just remove all of this.

Reviewers: labath, JDevlieghere, jingham, davide, vsk

Reviewed By: labath, vsk

Subscribers: JDevlieghere

Differential Revision: https://reviews.llvm.org/D77968