[all-commits] [llvm/llvm-project] 6474d1: [lld][WebAssembly] Do not require --shared-memory ...

[Thomas Lively via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6474d1b20ea74982f9446a11b367a5936b6bbbdd
      https://github.com/llvm/llvm-project/commit/6474d1b20ea74982f9446a11b367a5936b6bbbdd
  Author: Thomas Lively <tlively at google.com>
  Date:   2020-04-14 (Tue, 14 Apr 2020)

  Changed paths:
    M lld/test/wasm/driver.ll
    M lld/test/wasm/relocatable.ll
    M lld/test/wasm/shared-memory.yaml
    M lld/wasm/Driver.cpp
    M lld/wasm/Writer.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Do not require --shared-memory with --relocatable

Summary:
wasm-ld requires --shared-memory to be passed when the atomics feature
is enabled because historically atomic operations were only valid with
shared memories. This change relaxes that requirement for when
building relocatable objects because their memories are not
meaningful. This technically maintains the validity of object files
because the threads spec now allows atomic operations with unshared
memories, although we don't support that elsewhere in the tools yet.

This fixes and Emscripten build issue reported at
https://bugs.chromium.org/p/webp/issues/detail?id=463.

Reviewers: sbc100

Subscribers: dschuff, jgravelle-google, aheejin, sunfish, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78072