[all-commits] [llvm/llvm-project] 100483: [DWARFDebugLine] Check for (EOF) errors when parsi...

Pavel Labath via All-commits all-commits at lists.llvm.org
Tue Apr 14 07:03:21 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 100483b969b816e71cdfadfc591203c77e3e3fc7
      https://github.com/llvm/llvm-project/commit/100483b969b816e71cdfadfc591203c77e3e3fc7
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-04-14 (Tue, 14 Apr 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    A llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s

  Log Message:
  -----------
  [DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors

Summary:
Without that we could be silently reading zeroes, as that's the default
DataExtractor behavior. The entire parse would still most likely fail,
but it would do that with a seemingly unrelated/nonsensical error
message.

Reviewers: dblaikie, probinson, jhenderson

Subscribers: hiraditya, MaskRay, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77554




More information about the All-commits mailing list