[all-commits] [llvm/llvm-project] d63036: Reimplement mlir::Identifier to be a wrapper aroun...

[Chris Lattner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d63036c0efd2faf164cbf06328277539fad5cd74
      https://github.com/llvm/llvm-project/commit/d63036c0efd2faf164cbf06328277539fad5cd74
  Author: Chris Lattner <clattner at nondot.org>
  Date:   2020-04-13 (Mon, 13 Apr 2020)

  Changed paths:
    M mlir/include/mlir/IR/Identifier.h
    M mlir/lib/IR/MLIRContext.cpp

  Log Message:
  -----------
  Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry*' instead of a wrapper around a 'const char*'.  This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone.  While here...

Summary:
..., reimplement DenseMapInfo<mlir::Identifier>::getHashValue in terms of mlir::hash_value(Identifier).

Both of these improvements were suggested by River, thanks!

Reviewers: rriddle!

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77999