[all-commits] [llvm/llvm-project] 89c8ff: NFC: Clean up the implementation of StringPool a b...

Chris Lattner via All-commits all-commits at lists.llvm.org
Sun Apr 12 16:37:35 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 89c8ffd54221cfe2d0b5e391974143d08f047ae0
      https://github.com/llvm/llvm-project/commit/89c8ffd54221cfe2d0b5e391974143d08f047ae0
  Author: Chris Lattner <clattner at nondot.org>
  Date:   2020-04-12 (Sun, 12 Apr 2020)

  Changed paths:
    M llvm/include/llvm/ADT/StringMap.h
    M llvm/include/llvm/ADT/StringMapEntry.h
    M llvm/include/llvm/Support/StringPool.h
    M llvm/lib/IR/Value.cpp
    M llvm/lib/IR/ValueSymbolTable.cpp
    M llvm/lib/Support/StringPool.cpp
    M llvm/unittests/ADT/StringMapTest.cpp
    M llvm/unittests/ADT/StringSetTest.cpp

  Log Message:
  -----------
  NFC: Clean up the implementation of StringPool a bit, and remove dependence on some "implicitly MallocAllocator" based methods on StringMapEntry. This allows reducing the #includes in StringMapEntry.h.

Summary:
StringPool has many caveats and isn't used in the monorepo.  I will
propose removing it as a patch separate from this refactoring patch.

Reviewers: rriddle

Subscribers: hiraditya, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77976


  Commit: 4d9f5f135fad9eafa78ded8589af99a593415102
      https://github.com/llvm/llvm-project/commit/4d9f5f135fad9eafa78ded8589af99a593415102
  Author: Chris Lattner <clattner at nondot.org>
  Date:   2020-04-12 (Sun, 12 Apr 2020)

  Changed paths:
    M llvm/unittests/ADT/StringMapTest.cpp

  Log Message:
  -----------
  clang format one more line.


Compare: https://github.com/llvm/llvm-project/compare/cfb844265aad...4d9f5f135fad


More information about the All-commits mailing list