[all-commits] [llvm/llvm-project] f7de4b: Thread Plans pushed by a scripted plan should be p...

jimingham via All-commits all-commits at lists.llvm.org
Fri Apr 10 18:15:33 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f7de4b5d6bce8c33ac3e18a41abcf5268a29f461
      https://github.com/llvm/llvm-project/commit/f7de4b5d6bce8c33ac3e18a41abcf5268a29f461
  Author: Jim Ingham <jingham at apple.com>
  Date:   2020-04-10 (Fri, 10 Apr 2020)

  Changed paths:
    M lldb/source/API/SBThreadPlan.cpp

  Log Message:
  -----------
  Thread Plans pushed by a scripted plan should be private plans.

If a plan is not private, "thread plan discard" can discard it.  It would
not be hard to write reliable scripted plan if its subplans could get
removed out from under it.


  Commit: aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa
      https://github.com/llvm/llvm-project/commit/aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa
  Author: Jim Ingham <jingham at apple.com>
  Date:   2020-04-10 (Fri, 10 Apr 2020)

  Changed paths:
    M lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
    A lldb/test/API/functionalities/thread_plan/wrap_step_over.py

  Log Message:
  -----------
  Convert the ThreadPlanCommands test to use a scripted plan
that pushes a step over plan.  Relax the listing checker
so it will look past any entries after the ones listed in
the input patterns.  Then for the internal plans just check
for the StepOver plan that our scripted plan pushes, and look past
any others.

This should make the test more robust on systems that don't use the
step-in then push a step-out plan to step over a function.


Compare: https://github.com/llvm/llvm-project/compare/ed03d9485eb5...aa4b37b2acda


More information about the All-commits mailing list