[all-commits] [llvm/llvm-project] 416fa7: llvm-dwarfdump: Report errors when failing to pars...

[David Blaikie via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 416fa7720e30750939c53935051c6c750dfad2c2
      https://github.com/llvm/llvm-project/commit/416fa7720e30750939c53935051c6c750dfad2c2
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-04-10 (Fri, 10 Apr 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loc-error-cases.s
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loc-error-cases2.s
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loclists-error-cases.s
    M llvm/test/DebugInfo/X86/dwarfdump-debug-loclists-error-cases2.s
    M llvm/test/DebugInfo/X86/dwarfdump-ranges-baseaddr.s
    M llvm/test/DebugInfo/X86/dwarfdump-str-offsets-invalid-6.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_address_size_not_multiple.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_invalid_addr_size.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_reserved_length.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_segment_selector.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_small_length_field.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_extended_length_field.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_length_field.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_section.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_addr_unsupported_version.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_rnglists.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_rnglists_invalid.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_rnglists_reserved_length.s
    M llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

  Log Message:
  -----------
  llvm-dwarfdump: Report errors when failing to parse loclist/debug_loc entries

This probably isn't ideal - the error was being printed specifically
inline with the dumping that was more legible - but then the error
wasn't reported to stderr and didn't produce a non-zero exit code.

Probably the error message could be improved by adding more context now
that it isn't printed in-situ of the DIE dumping as much.