[all-commits] [llvm/llvm-project] 89f132: [clang-tidy] Add check to find calls to NSInvocati...

[Michael Wyman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 89f1321fe4ef203a4674213280b430a274dc2001
      https://github.com/llvm/llvm-project/commit/89f1321fe4ef203a4674213280b430a274dc2001
  Author: Michael Wyman <michael at mwyman.com>
  Date:   2020-04-10 (Fri, 10 Apr 2020)

  Changed paths:
    M clang-tools-extra/clang-tidy/objc/CMakeLists.txt
    A clang-tools-extra/clang-tidy/objc/NSInvocationArgumentLifetimeCheck.cpp
    A clang-tools-extra/clang-tidy/objc/NSInvocationArgumentLifetimeCheck.h
    M clang-tools-extra/clang-tidy/objc/ObjCTidyModule.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/objc-nsinvocation-argument-lifetime.rst
    A clang-tools-extra/test/clang-tidy/checkers/objc-nsinvocation-argument-lifetime.m

  Log Message:
  -----------
  [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

Summary: This check is similar to an ARC Migration check that warned about this incorrect usage under ARC, but most projects are no longer undergoing migration from pre-ARC code. The documentation for NSInvocation is not explicit about these requirements and incorrect usage has been found in many of our projects.

Reviewers: stephanemoore, benhamilton, dmaclach, alexfh, aaron.ballman, hokein, njames93

Reviewed By: stephanemoore, benhamilton, aaron.ballman

Subscribers: xazax.hun, Eugene.Zelenko, mgorny, cfe-commits

Tags: #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D77571