[all-commits] [llvm/llvm-project] f3d460: [libunwind] Clean up __arm64__

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Apr 9 15:47:10 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f3d460ce5874e4dd12b8cf8b227de4cec43a685c
      https://github.com/llvm/llvm-project/commit/f3d460ce5874e4dd12b8cf8b227de4cec43a685c
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M libunwind/src/UnwindRegistersRestore.S
    M libunwind/src/UnwindRegistersSave.S
    M libunwind/src/Unwind_AppleExtras.cpp
    M libunwind/src/assembly.h
    M libunwind/src/config.h

  Log Message:
  -----------
  [libunwind] Clean up __arm64__

`__aarch64__` is defined for the target (since the beginning of arm64 support: clang 3.5).
`__arm64__` is only defined for the Darwin OS on AArch64.

`defined(__aarch64__) || defined(__arm64__)` can be simplied as `defined(__aarch64__)`

Darwin AArch64 uses %% as the assembly separator (see AArch64MCAsmInfo.cpp).
Make the intention explicit in src/assembly.h

With this change, the libunwind code base has no reference of `__arm64__`/`__arm64`.

Reviewed By: #libunwind, ldionne, mstorsjo

Differential Revision: https://reviews.llvm.org/D77829




More information about the All-commits mailing list